[NFC] [clang] fix unused variable warning #126796
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.4
fmayer
added
the
skip-precommit-approval
fmayer
deleted the
users/fmayer/spr/nfc-clang-fix-unused-variable-warning
branch
llvmbot
added
clang
Member
|
@llvm/pr-subscribers-clang Author: Florian Mayer (fmayer) ChangesFull diff: https://github.com/llvm/llvm-project/pull/126796.diff 1 Files Affected:
diff --git a/clang/lib/StaticAnalyzer/Checkers/WebKit/ASTUtils.cpp b/clang/lib/StaticAnalyzer/Checkers/WebKit/ASTUtils.cpp
index 6452dedb8c391..1411bf1d1c237 100644
--- a/clang/lib/StaticAnalyzer/Checkers/WebKit/ASTUtils.cpp
+++ b/clang/lib/StaticAnalyzer/Checkers/WebKit/ASTUtils.cpp
@@ -156,7 +156,7 @@ bool isConstOwnerPtrMemberExpr(const clang::Expr *E) {
auto Name = safeGetName(Callee);
if (Name == "get" || Name == "ptr")
E = MCE->getImplicitObjectArgument();
- if (auto *CD = dyn_cast<CXXConversionDecl>(Callee))
+ if (dyn_cast<CXXConversionDecl>(Callee))
E = MCE->getImplicitObjectArgument();
}
} else if (auto *OCE = dyn_cast<CXXOperatorCallExpr>(E)) {
|
Member
|
@llvm/pr-subscribers-clang-static-analyzer-1 Author: Florian Mayer (fmayer) ChangesFull diff: https://github.com/llvm/llvm-project/pull/126796.diff 1 Files Affected:
diff --git a/clang/lib/StaticAnalyzer/Checkers/WebKit/ASTUtils.cpp b/clang/lib/StaticAnalyzer/Checkers/WebKit/ASTUtils.cpp
index 6452dedb8c391..1411bf1d1c237 100644
--- a/clang/lib/StaticAnalyzer/Checkers/WebKit/ASTUtils.cpp
+++ b/clang/lib/StaticAnalyzer/Checkers/WebKit/ASTUtils.cpp
@@ -156,7 +156,7 @@ bool isConstOwnerPtrMemberExpr(const clang::Expr *E) {
auto Name = safeGetName(Callee);
if (Name == "get" || Name == "ptr")
E = MCE->getImplicitObjectArgument();
- if (auto *CD = dyn_cast<CXXConversionDecl>(Callee))
+ if (dyn_cast<CXXConversionDecl>(Callee))
E = MCE->getImplicitObjectArgument();
}
} else if (auto *OCE = dyn_cast<CXXOperatorCallExpr>(E)) {
|
steakhal
reviewed
Feb 11, 2025
Contributor
steakhal
left a comment
steakhal
left a comment
There was a problem hiding this comment.
I think isa should be preferred if the result of dyncast is not used.
Same applied to the surrounding ifs too.
Contributor
|
Ah, so this one is already merged. Then nvm. It's not worth a followup. |
rniwa
reviewed
Feb 11, 2025
Contributor
rniwa
left a comment
rniwa
left a comment
There was a problem hiding this comment.
Oh oops, thank you for the fix. It's odd that the checks didn't catch this before the merge...
Contributor
Author
|
Icohedron
pushed a commit
to Icohedron/llvm-project
that referenced
this pull request
Feb 11, 2025
rniwa
pushed a commit
to rniwa/llvm-project
that referenced
this pull request
Feb 12, 2025
flovent
pushed a commit
to flovent/llvm-project
that referenced
this pull request
Feb 13, 2025
joaosaffran
pushed a commit
to joaosaffran/llvm-project
that referenced
this pull request
Feb 14, 2025
sivan-shani
pushed a commit
to sivan-shani/llvm-project
that referenced
this pull request
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.